Files
cv-site/static/hyperscript/utils._hs
T
juanatsap ba44b435e7 refactor: Major hyperscript refactoring and JS elimination
Inline Hyperscript Refactoring:
- Body tag keyboard handlers: 20→8 lines (using helper functions)
- Zoom control handlers: 85→35 lines (using zoom._hs)
- PDF modal card selection: 90→6 lines (3 identical blocks eliminated)

New Hyperscript Files:
- zoom._hs: handleZoomInput, handleZoomReset, initZoomControl
- pdf-modal._hs: selectPdfCard, handlePdfCardKey

JavaScript Elimination (232 lines removed):
- cv-functions.js: REMOVED - hyperscript defs are globally available
- scroll-at-bottom-handler.js: REMOVED - duplicate of handleScroll()
- footer-buttons-interaction.js: REMOVED - moved to hyperscript

Added Tests:
- 32-hyperscript-multi-src.test.mjs: Verifies multi-file loading
- 33-keyboard-shortcuts-refactored.test.mjs: Keyboard shortcuts
- 34-hyperscript-refactor-comprehensive.test.mjs: Full test suite

Key Findings:
- No hyperscript multi-file bug in 0.9.14
- Hyperscript def statements are globally accessible
- Previous refactoring failures were syntax errors, not library bugs
2025-11-30 05:58:44 +00:00

157 lines
4.8 KiB
Plaintext

-- ==============================================================================
-- CV Site - Hyperscript Functions
-- ==============================================================================
-- Global hyperscript functions for CV interactive features
-- Keeps HTML templates clean and behavior organized
-- ==============================================================================
-- PRINT FUNCTIONS
-- ==============================================================================
def printFriendly()
-- Store current state
set container to the first .cv-container
set paper to the first .cv-paper
set wasClean to container.classList.contains('theme-clean')
set wasLong to paper.classList.contains('cv-long')
set currentZoom to localStorage.getItem('cv-zoom') or '100'
-- Apply print-friendly settings
if wasClean is false
add .theme-clean to container
end
remove .cv-long from paper
add .cv-short to paper
-- Reset zoom for consistent printing
set #zoom-wrapper's *zoom to 1
-- Let CSS apply, then print
wait 50ms
call window.print()
-- Wait for print dialog to close, then restore
wait 100ms
-- Restore original theme
if wasClean is false
remove .theme-clean from container
end
-- Restore original length
if wasLong is true
remove .cv-short from paper
add .cv-long to paper
end
-- Restore original zoom by triggering slider input event
if currentZoom is not '100'
set #zoom-slider's value to currentZoom
send input to #zoom-slider
end
end
-- ==============================================================================
-- SCROLL BEHAVIOR
-- ==============================================================================
def initScrollBehavior()
set :lastScroll to 0
set :scrollThreshold to 100
set :keepHeaderVisible to false
end
def handleScroll()
set currentScroll to window.pageYOffset
set menu to the first .navigation-menu
set isMenuOpen to menu.classList.contains('menu-open')
-- Calculate if at bottom (within 50px)
set scrollHeight to document.documentElement.scrollHeight
set clientHeight to document.documentElement.clientHeight
set isAtBottom to (scrollHeight - currentScroll - clientHeight) < 50
-- Reset keepHeaderVisible when scrolling up
if currentScroll < :lastScroll
set :keepHeaderVisible to false
end
-- Header visibility: Scrolling down past threshold
if currentScroll > :scrollThreshold and currentScroll > :lastScroll and :keepHeaderVisible is false
add .header-hidden to .action-bar
if isMenuOpen is true
add .header-hidden to menu
end
end
-- Header visibility: Scrolling up past threshold
if currentScroll > :scrollThreshold and (currentScroll <= :lastScroll or :keepHeaderVisible is true)
remove .header-hidden from .action-bar
if isMenuOpen is true
remove .header-hidden from menu
end
end
-- Header visibility: At top
if currentScroll <= :scrollThreshold
remove .header-hidden from .action-bar
if isMenuOpen is true
remove .header-hidden from menu
end
end
-- Back to top button visibility
if currentScroll > 300
set #back-to-top's *display to 'flex'
end
if currentScroll <= 300
set #back-to-top's *display to 'none'
end
-- At-bottom class for fixed buttons
if isAtBottom
add .at-bottom to #back-to-top
add .at-bottom to #info-button
add .at-bottom to #shortcuts-button
add .at-bottom to #download-button
add .at-bottom to #print-friendly-button
add .at-bottom to .color-theme-switcher
add .at-bottom to #zoom-toggle-button
end
if not isAtBottom
remove .at-bottom from #back-to-top
remove .at-bottom from #info-button
remove .at-bottom from #shortcuts-button
remove .at-bottom from #download-button
remove .at-bottom from #print-friendly-button
remove .at-bottom from .color-theme-switcher
remove .at-bottom from #zoom-toggle-button
end
-- Update last scroll position
set :lastScroll to currentScroll
end
-- ==============================================================================
-- FOOTER HOVER INTERACTION
-- ==============================================================================
-- Adds/removes footer-hovered class to fixed buttons when hovering footer
def setFooterHover(show)
set buttons to document.querySelectorAll('.download-btn, .print-friendly-btn, .shortcuts-btn, .info-button, .back-to-top, .color-theme-switcher')
for btn in buttons
if show
add .footer-hovered to btn
else
remove .footer-hovered from btn
end
end
end
-- ==============================================================================
-- KEYBOARD SHORTCUTS
-- ==============================================================================
-- Note: Keyboard event handlers are now defined inline in the body tag
-- because hyperscript 0.9.12 doesn't support nested event handlers (on ... inside def)