txeo/cv-site
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve errcheck warnings in security_test.go

Browse Source 
Use t.Setenv for env var management in tests.
This commit is contained in:
juanatsap
2026-03-15 20:21:50 +00:00
parent cafd117437
commit 1d0cf46dd3
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/middleware/security_test.go
+6 -9
View File
@@ -53,8 +53,7 @@ func TestSecurityHeaders(t *testing.T) {
func TestSecurityHeaders_HSTS(t *testing.T) {
// Test in production mode
os.Setenv(c.EnvVarGOEnv, c.EnvProduction)
defer os.Unsetenv(c.EnvVarGOEnv)
t.Setenv(c.EnvVarGOEnv, c.EnvProduction)
handler := SecurityHeaders(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
@@ -71,7 +70,7 @@ func TestSecurityHeaders_HSTS(t *testing.T) {
}
// Test in development mode
os.Setenv(c.EnvVarGOEnv, c.EnvDevelopment)
t.Setenv(c.EnvVarGOEnv, c.EnvDevelopment)
w = httptest.NewRecorder()
handler.ServeHTTP(w, req)
@@ -474,7 +473,7 @@ func TestCacheControl(t *testing.T) {
}))
// Development mode
os.Unsetenv(c.EnvVarGOEnv)
_ = os.Unsetenv(c.EnvVarGOEnv)
req := httptest.NewRequest(http.MethodGet, "/static/file.css", nil)
w := httptest.NewRecorder()
handler.ServeHTTP(w, req)
@@ -484,8 +483,7 @@ func TestCacheControl(t *testing.T) {
}
// Production mode
os.Setenv(c.EnvVarGOEnv, c.EnvProduction)
defer os.Unsetenv(c.EnvVarGOEnv)
t.Setenv(c.EnvVarGOEnv, c.EnvProduction)
w = httptest.NewRecorder()
handler.ServeHTTP(w, req)
@@ -501,7 +499,7 @@ func TestDynamicCacheControl(t *testing.T) {
}))
// Development mode - no cache
os.Unsetenv(c.EnvVarGOEnv)
_ = os.Unsetenv(c.EnvVarGOEnv)
req := httptest.NewRequest(http.MethodGet, "/", nil)
w := httptest.NewRecorder()
handler.ServeHTTP(w, req)
@@ -511,8 +509,7 @@ func TestDynamicCacheControl(t *testing.T) {
}
// Production mode - short cache
os.Setenv(c.EnvVarGOEnv, c.EnvProduction)
defer os.Unsetenv(c.EnvVarGOEnv)
t.Setenv(c.EnvVarGOEnv, c.EnvProduction)
w = httptest.NewRecorder()
handler.ServeHTTP(w, req)