juanatsap
7b60fdcf9c
**Main Changes:** 1. **Package Restructuring** - Separated mixed concerns into focused packages: - Created `internal/models/cv/` for CV domain logic (CV, Personal, Experience, etc.) - Created `internal/models/ui/` for UI presentation logic (InfoModal, ShortcutsModal, etc.) - Removed monolithic `internal/models/cv.go` (300+ lines → organized packages) 2. **Testing** - Added comprehensive unit tests: - `internal/models/cv/loader_test.go` - CV data loading and validation - `internal/models/ui/loader_test.go` - UI translations loading - All tests passing ✅ 3. **Documentation** - Added Go learning knowledge base: - `_go-learning/architecture/server-design.md` - Goroutines, graceful shutdown explained - `_go-learning/refactorings/001-cv-model-separation.md` - This refactoring documented - Public documentation showcasing Go expertise (README.md kept private) 4. **Handler Updates** - Updated imports to use new package structure: - `internal/handlers/cv.go` - Uses `cvmodel` and `uimodel` aliases **Benefits:** - ✅ Clear separation of concerns (domain vs presentation) - ✅ Better testability (isolated package testing) - ✅ Improved maintainability (smaller, focused files) - ✅ Scalability (each domain can evolve independently) - ✅ Follows Go best practices (small, cohesive packages) **Other Updates:** - Updated middleware security checks - Template improvements - Organized completed prompts **Testing:** - All Go unit tests pass (cv, ui, handlers) - Server verified with curl tests (English, Spanish, Health endpoints) - Frontend functionality unchanged (refactoring is transparent to UI)
99 lines
2.0 KiB
Go
99 lines
2.0 KiB
Go
package ui_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/juanatsap/cv-site/internal/models/ui"
|
|
)
|
|
|
|
func TestLoadUI(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
lang string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "English UI",
|
|
lang: "en",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "Spanish UI",
|
|
lang: "es",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "Invalid language",
|
|
lang: "fr",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "Empty language",
|
|
lang: "",
|
|
wantErr: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
uiData, err := ui.LoadUI(tt.lang)
|
|
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("LoadUI() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
|
|
if !tt.wantErr {
|
|
if uiData == nil {
|
|
t.Error("LoadUI() returned nil UI data")
|
|
return
|
|
}
|
|
|
|
// Validate UI has essential data
|
|
if uiData.InfoModal.Title == "" {
|
|
t.Error("LoadUI() returned UI with empty InfoModal title")
|
|
}
|
|
|
|
if uiData.ShortcutsModal.Title == "" {
|
|
t.Error("LoadUI() returned UI with empty ShortcutsModal title")
|
|
}
|
|
|
|
// Validate TechStack is populated
|
|
if uiData.InfoModal.TechStack.GoHono == "" {
|
|
t.Error("LoadUI() returned UI with empty TechStack.GoHono")
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestLoadUI_ModalData(t *testing.T) {
|
|
uiData, err := ui.LoadUI("en")
|
|
if err != nil {
|
|
t.Fatalf("LoadUI() failed: %v", err)
|
|
}
|
|
|
|
// Test InfoModal structure
|
|
if uiData.InfoModal.Description == "" {
|
|
t.Error("InfoModal.Description should not be empty")
|
|
}
|
|
|
|
if uiData.InfoModal.ViewSource == "" {
|
|
t.Error("InfoModal.ViewSource should not be empty")
|
|
}
|
|
|
|
// Test ShortcutsModal structure
|
|
if uiData.ShortcutsModal.Description == "" {
|
|
t.Error("ShortcutsModal.Description should not be empty")
|
|
}
|
|
|
|
// Test that shortcuts sections exist
|
|
if uiData.ShortcutsModal.Sections.Zoom.Title == "" {
|
|
t.Error("Zoom shortcuts section should have a title")
|
|
}
|
|
|
|
if uiData.ShortcutsModal.Sections.Actions.Title == "" {
|
|
t.Error("Actions shortcuts section should have a title")
|
|
}
|
|
}
|