Files
cv-site/internal/handlers/cv_pages.go
T
juanatsap ae89d84e07 refactor: Integrate PreferencesMiddleware and update handlers
Complete middleware integration with comprehensive testing:

1. Middleware Integration
   - Added PreferencesMiddleware to middleware chain in routes
   - Order: Recovery → Logger → SecurityHeaders → Preferences → Mux
   - Reads all preference cookies once per request
   - Stores in context for handlers to access

2. Handler Updates
   - cv_pages.go: Home handler uses middleware.GetPreferences()
   - cv_htmx.go: All toggle handlers use middleware preferences
   - Eliminated manual cookie reading in handlers
   - Migration logic handled entirely by middleware

3. Comprehensive Middleware Tests
   - Created preferences_test.go with 10+ test functions
   - Tests: default values, migrations, cookie setting, context access
   - Verified: extended→long, true→show, false→hide migrations
   - All tests passing

Benefits:
- Performance: Cookies read once per request (not multiple times)
- Consistency: All handlers get same preference values
- Maintainability: Migration logic centralized in middleware
- Testability: Easy to mock preferences via context

Testing:
- All unit tests pass (handlers + middleware)
- Build succeeds
- No breaking changes
2025-11-20 17:56:47 +00:00

189 lines
5.4 KiB
Go

package handlers
import (
"fmt"
"log"
"net/http"
"path/filepath"
"strings"
"time"
"github.com/juanatsap/cv-site/internal/middleware"
"github.com/juanatsap/cv-site/internal/pdf"
)
// ==============================================================================
// PAGE HANDLERS
// These handlers render full HTML pages or page sections
// ==============================================================================
// Home renders the full CV page
func (h *CVHandler) Home(w http.ResponseWriter, r *http.Request) {
// Check if this is a shortcut URL request (cv-jamr-{year}-{lang}.pdf)
if strings.HasPrefix(r.URL.Path, "/cv-jamr-") && strings.HasSuffix(r.URL.Path, ".pdf") {
h.DefaultCVShortcut(w, r)
return
}
// Get language from query parameter, default to English
lang := r.URL.Query().Get("lang")
if lang == "" {
lang = "en"
}
// Validate language
if lang != "en" && lang != "es" {
HandleError(w, r, BadRequestError("Unsupported language. Use 'en' or 'es'"))
return
}
// Prepare template data using shared helper
data, err := h.prepareTemplateData(lang)
if err != nil {
HandleError(w, r, DataLoadError(err, "CV"))
return
}
// Get user preferences from context (set by PreferencesMiddleware)
prefs := middleware.GetPreferences(r)
// Use preferences from context (already migrated by middleware)
cvLength := prefs.CVLength
cvIcons := prefs.CVIcons
cvTheme := prefs.CVTheme
// Add preference-specific fields to template data
cvLengthClass := "cv-short"
if cvLength == "long" {
cvLengthClass = "cv-long"
}
data["CVLengthClass"] = cvLengthClass
data["ShowIcons"] = (cvIcons == "show")
data["ThemeClean"] = (cvTheme == "clean")
// Render template
tmpl, err := h.templates.Render("index.html")
if err != nil {
HandleError(w, r, TemplateError(err, "index.html"))
return
}
w.Header().Set("Content-Type", "text/html; charset=utf-8")
if err := tmpl.Execute(w, data); err != nil {
HandleError(w, r, TemplateError(err, "index.html"))
return
}
}
// CVContent renders just the CV content for HTMX swaps
func (h *CVHandler) CVContent(w http.ResponseWriter, r *http.Request) {
// Get language from query parameter
lang := r.URL.Query().Get("lang")
if lang == "" {
lang = "en"
}
// Validate language
if lang != "en" && lang != "es" {
HandleError(w, r, BadRequestError("Unsupported language. Use 'en' or 'es'"))
return
}
// Prepare template data using shared helper
data, err := h.prepareTemplateData(lang)
if err != nil {
HandleError(w, r, DataLoadError(err, "CV"))
return
}
// Render template
tmpl, err := h.templates.Render("cv-content.html")
if err != nil {
HandleError(w, r, TemplateError(err, "cv-content.html"))
return
}
w.Header().Set("Content-Type", "text/html; charset=utf-8")
if err := tmpl.Execute(w, data); err != nil {
HandleError(w, r, TemplateError(err, "cv-content.html"))
return
}
}
// DefaultCVShortcut handles shortcut URLs for default CV downloads
// Pattern: /cv-jamr-{year}-{lang}.pdf (e.g., /cv-jamr-2025-en.pdf)
// Validates year matches current year and redirects to default PDF export
func (h *CVHandler) DefaultCVShortcut(w http.ResponseWriter, r *http.Request) {
// Extract path (e.g., "/cv-jamr-2025-en.pdf")
path := r.URL.Path
log.Printf("DefaultCVShortcut called with path: %s", path)
// Parse filename pattern: cv-jamr-{year}-{lang}.pdf
parts := strings.Split(strings.TrimPrefix(path, "/"), "-")
if len(parts) != 4 {
http.NotFound(w, r)
return
}
// Extract year and language
yearStr := parts[2]
langWithExt := parts[3] // "en.pdf" or "es.pdf"
lang := strings.TrimSuffix(langWithExt, ".pdf")
// Validate language
if lang != "en" && lang != "es" {
http.NotFound(w, r)
return
}
// Validate year matches current year
currentYear := fmt.Sprintf("%d", time.Now().Year())
if yearStr != currentYear {
// Return 404 if year doesn't match (old or future URLs)
log.Printf("Invalid year in shortcut URL: %s (current: %s)", yearStr, currentYear)
http.NotFound(w, r)
return
}
// Generate PDF directly instead of redirecting
// This ensures the Content-Disposition filename is respected by browsers
log.Printf("Shortcut URL: %s → generating PDF (short + with_skills)", path)
// Prepare cookies for PDF generation (short, with_skills, light mode)
cookies := map[string]string{
"cv-length": "short",
"cv-icons": "show",
"cv-language": lang,
"cv-theme": "default", // with_skills = default theme
"color-theme": "light", // Always light for PDFs
}
// Construct URL for PDF generation
targetURL := fmt.Sprintf("http://%s/?lang=%s", h.serverAddr, lang)
// Generate PDF with screen render mode (for sidebar layout)
ctx := r.Context()
pdfData, err := h.pdfGenerator.GenerateFromURLWithOptions(ctx, targetURL, cookies, pdf.RenderModeScreen)
if err != nil {
log.Printf("PDF generation failed for shortcut URL: %v", err)
HandleError(w, r, InternalError(err))
return
}
// Use the shortcut filename directly (simple, user-friendly)
filename := filepath.Base(path) // cv-jamr-2025-en.pdf
// Set response headers with shortcut filename
w.Header().Set("Content-Type", "application/pdf")
w.Header().Set("Content-Disposition", fmt.Sprintf("attachment; filename=%s", filename))
w.Header().Set("Content-Length", fmt.Sprintf("%d", len(pdfData)))
// Write PDF data
if _, err := w.Write(pdfData); err != nil {
log.Printf("Error writing PDF response: %v", err)
return
}
log.Printf("PDF generated successfully: %s (%d bytes)", filename, len(pdfData))
}