23f63e77fe
fix: Update build tag to new Go 1.17+ format
...
- Change '// +build integration' to '//go:build integration'
- Fixes golangci-lint govet warning about deprecated build tag format
2025-11-20 14:06:01 +00:00
96d34d5f6f
test: Mark PDF tests as integration tests (skip in CI)
...
- Add '// +build integration' tag to exclude from default test runs
- CI runs fast unit tests only (no Chrome dependency)
- Full test suite available with: go test -tags=integration ./...
PDF tests require Chrome browser and are run manually before releases.
2025-11-20 14:00:43 +00:00
54cdb0cc19
refactor: PDF filenames with_skills → with-skills (cosmetic only)
...
Changed PDF filename format to use hyphens instead of underscores for
consistency with other filename components, while keeping API parameter
as `version=with_skills`.
## Changes
**Backend:**
- internal/handlers/cv.go: Add underscore-to-hyphen conversion in filename generation
- New logic: `strings.ReplaceAll(version, "_", "-")` for filename only
- API parameter unchanged: still accepts `version=with_skills`
**Tests:**
- internal/handlers/pdf_test.go: Update expected filenames to use hyphens
- cv-*-with_skills-*.pdf → cv-*-with-skills-*.pdf
**Documentation:**
- Updated all PDF filename references to use hyphens
- PDF-EXPORT-FEATURE.md
- doc/LONG-PDF-GENERATION.md
- PDF-VALIDATION-REPORT.md (new validation report)
**PDFs:**
- Regenerated all 8 PDFs with new naming convention
- Old: cv-short-with_skills-jamr-2025-en.pdf
- New: cv-short-with-skills-jamr-2025-en.pdf
## Examples
API calls unchanged:
- GET /export/pdf?version=with_skills (still works)
Generated filenames:
- cv-short-with-skills-jamr-2025-en.pdf ✓
- cv-long-with-skills-jamr-2025-es.pdf ✓
**Tests:** All passing ✓
**API:** Backwards compatible ✓
2025-11-20 11:48:34 +00:00
b44f9b9a99
refactor: Rename 'extended' → 'long' + add compact sidebar fonts
...
BREAKING CHANGE: API parameter renamed from 'extended' to 'long'
## Breaking Change: Terminology Standardization
Renamed 'extended' to 'long' across entire codebase for consistency:
**Backend (Go):**
- internal/handlers/cv.go (7 locations)
- Migration logic to auto-convert 'extended' → 'long' cookies
- API validation now rejects 'extended', requires 'long'
- Toggle state logic updated
- internal/handlers/pdf_test.go (17 occurrences)
- Test function renamed: TestExportPDF_ExtendedWithSkills → TestExportPDF_LongWithSkills
- All test cases, parameters, and expected filenames updated
- internal/pdf/generator.go (2 comment updates)
**Frontend:**
- PDF-EXPORT-FEATURE.md (3 occurrences)
- doc/3-API.md (parameter documentation)
- doc/7-CUSTOMIZATION.md (examples updated)
- templates/partials/modals/pdf-modal.html (button text, URLs)
- static/js/main.js (migration logic)
- static/hyperscript/toggles._hs (toggle logic)
- tests/mjs/24-pdf-download-params.test.mjs (test expectations)
- tests/mjs/test-preference-migration.test.mjs (NEW)
- tests/mjs/verify-migration.test.mjs (NEW)
**PDFs Renamed:**
- cv-extended-with_skills-jamr-2025-en.pdf → cv-long-with_skills-jamr-2025-en.pdf
- cv-extended-with_skills-jamr-2025-es.pdf → cv-long-with_skills-jamr-2025-es.pdf
**Migration:** Automatic cookie migration from 'extended' → 'long' for seamless UX
## New Feature: Compact Sidebar Fonts
Reduces page count for short CV with skills from 6 → 5 pages:
**Implementation:**
- Location: internal/pdf/generator.go (lines 154-215)
- Cookie detection: `cookies["cv-length"] == "short"`
- Font reduction: 2-6% (0.94-0.98em) - very subtle
- Only activates for: `length=short` + `version=with_skills`
- Long version: Always uses full-size fonts
**Impact:**
- Page count: 6 pages → 5 pages (16.7% reduction)
- Readability: Maintained - fonts remain professional
- Design philosophy: Subtle, natural content flow
**Testing:**
- New test: TestPDFGenerator_CompactSidebarFonts
- Comprehensive coverage of cookie detection and PDF generation
- Manual verification: 5-page PDF with compact but readable fonts
**Documentation:**
- doc/LONG-PDF-GENERATION.md (NEW, 13 KB)
- Complete feature documentation
- Implementation details with code examples
- Font size breakdown table
- Testing and troubleshooting guides
- Compact sidebar fonts section (comprehensive)
**Files Changed:**
- 11 modified (backend + frontend + docs)
- 5 new files (2 PDFs, 1 doc, 2 tests)
- 2 files renamed (PDFs)
**Tests:** All Go tests passing, API validation verified, PDF generation tested
2025-11-20 11:21:43 +00:00
12bd9c7cd8
feat: enhance PDF export with 4 customizable parameters
...
Add comprehensive parameter support to /export/pdf endpoint:
- lang: Language selection (en/es)
- length: CV length (short/long)
- icons: Icon visibility (show/hide)
- version: Theme variant (extended/clean)
Backend Changes:
- Enhanced PDF generator with cookie injection for user preferences
- Cookies set before chromedp navigation to apply all preferences
- Updated filename pattern: CV-{Name}-{lang}-{length}-{version}.pdf
- Comprehensive parameter validation with descriptive error messages
- All parameters optional with sensible defaults (en, short, show, extended)
Testing:
- Added pdf_test.go with parameter validation tests
- Tests cover all valid/invalid parameter combinations
- Tests verify default parameter application
Documentation:
- Updated API documentation (doc/3-API.md)
- Added detailed parameter descriptions and examples
- Updated quick reference with all parameter options
- Added process flow diagram showing cookie injection
- Documented error responses for each invalid parameter
Implementation Details:
- Cookie domain set to "localhost" for chromedp context
- Cookies: cv-language, cv-length, cv-icons, cv-theme
- PDF generation leverages existing @media print CSS
- No changes to frontend CSS or templates
Tested:
- Parameter validation (✅ All invalid params rejected correctly)
- Default parameters (✅ Applied when params omitted)
- PDF generation with all parameter combinations (✅ Working)
2025-11-19 10:43:19 +00:00
juanatsap