refactor: migrate toggle and hover sync functions from JavaScript to Hyperscript

BREAKING: Removed JavaScript toggle functions in favor of organized Hyperscript architecture Changes: - Created organized Hyperscript file structure (no def limit with latest version): • static/hyperscript/utils._hs (utility functions) • static/hyperscript/toggles._hs (CV length, icons, theme toggles) • static/hyperscript/hover-sync._hs (PDF/Print hover sync + zoom highlight) - Removed functions._hs (renamed to utils._hs for better organization) - Emptied static/js/cv-functions.js (kept file with migration notice) • toggleCVLength, toggleIcons, toggleTheme → toggles._hs • syncPdfHover, syncPrintHover, highlightZoomControl → hover-sync._hs - Updated templates/index.html to load all 3 new hyperscript files - Updated tests/mjs/1-toggles.test.mjs for responsive design • Added viewport detection for desktop vs mobile toggles • Tests now adapt to screen size Rationale: - Test 9 confirmed NO def limit with latest hyperscript (tested up to 5 defs) - Better separation of concerns with category-based file organization - Aligns with server-side hypermedia pattern (HTMX + Hyperscript) - Eliminates workaround JavaScript duplication - 9 total def statements across 3 files (proving no limit) Verified: ✅ All hyperscript files load successfully (HTTP 200) ✅ Hyperscript library loads without errors ✅ Functions work correctly in browser ✅ No console errors ✅ Test 9 (def limit) passes with 5 def statements Related: Test 9 verification (tests/mjs/9-hyperscript-def-limit.test.mjs)
2025-11-17 16:28:52 +00:00
parent 5d5b050029
commit d2330f5d48
6 changed files with 222 additions and 131 deletions
@@ -1,121 +1,24 @@
 /**
- * CV Site - Core Toggle Functions
- * =================================
- * Global JavaScript functions for CV toggles and interactions
- * These replace hyperscript def functions to avoid the 3-function parser limit
+ * CV Site - Core Functions
+ * =========================
+ *
+ * MIGRATION NOTICE (2025-11-17):
+ * ==============================
+ * Toggle and hover sync functions have been migrated to Hyperscript.
+ *
+ * Previous functions (now in hyperscript files):
+ * - toggleCVLength() → static/hyperscript/toggles._hs
+ * - toggleIcons() → static/hyperscript/toggles._hs
+ * - toggleTheme() → static/hyperscript/toggles._hs
+ * - syncPdfHover() → static/hyperscript/hover-sync._hs
+ * - syncPrintHover() → static/hyperscript/hover-sync._hs
+ * - highlightZoomControl() → static/hyperscript/hover-sync._hs
+ *
+ * Reason for migration:
+ * - Latest hyperscript version has NO def statement limit
+ * - Test verified: 5 def statements work perfectly
+ * - Better separation of concerns with organized hyperscript files
+ * - Server-side hypermedia pattern alignment
+ *
+ * This file is kept for future JavaScript-only functionality if needed.
 */
-
-/**
- * Toggle CV Length (Short/Long)
- * @param {boolean} isLong - true for long CV, false for short
- */
-function toggleCVLength(isLong) {
-  const paper = document.querySelector('.cv-paper');
-  const otherToggle = document.querySelector('#lengthToggle') || document.querySelector('#lengthToggleMenu');
-
-  if (isLong) {
-    paper?.classList.remove('cv-short');
-    paper?.classList.add('cv-long');
-    localStorage.setItem('cv-length', 'long');
-    if (otherToggle) otherToggle.checked = true;
-  } else {
-    paper?.classList.remove('cv-long');
-    paper?.classList.add('cv-short');
-    localStorage.setItem('cv-length', 'short');
-    if (otherToggle) otherToggle.checked = false;
-  }
-}
-
-/**
- * Toggle Icons Display
- * @param {boolean} showIcons - true to show icons, false to hide
- */
-function toggleIcons(showIcons) {
-  const paper = document.querySelector('.cv-paper');
-  const otherToggle = document.querySelector('#iconToggle') || document.querySelector('#iconToggleMenu');
-
-  if (showIcons) {
-    paper?.classList.add('show-icons');
-    localStorage.setItem('cv-icons', 'true');
-    if (otherToggle) otherToggle.checked = true;
-  } else {
-    paper?.classList.remove('show-icons');
-    localStorage.setItem('cv-icons', 'false');
-    if (otherToggle) otherToggle.checked = false;
-  }
-}
-
-/**
- * Toggle Theme (Default/Clean)
- * @param {boolean} isClean - true for clean theme, false for default
- */
-function toggleTheme(isClean) {
-  const body = document.body;
-  const otherToggle = document.querySelector('#themeToggle') || document.querySelector('#themeToggleMenu');
-
-  if (isClean) {
-    body?.classList.add('theme-clean');
-    localStorage.setItem('cv-theme', 'clean');
-    if (otherToggle) otherToggle.checked = true;
-  } else {
-    body?.classList.remove('theme-clean');
-    localStorage.setItem('cv-theme', 'default');
-    if (otherToggle) otherToggle.checked = false;
-  }
-}
-
-/**
- * Sync PDF Button Hover State
- * @param {boolean} show - true to add hover class, false to remove
- */
-function syncPdfHover(show) {
-  // Select both action bar PDF button and menu PDF button
-  const pdfButtons = document.querySelectorAll('.pdf-btn, .menu-pdf-btn');
-
-  pdfButtons.forEach(button => {
-    if (show) {
-      button.classList.add('pdf-hover-sync');
-    } else {
-      button.classList.remove('pdf-hover-sync');
-    }
-  });
-}
-
-/**
- * Sync Print Button Hover State
- * @param {boolean} show - true to add hover class, false to remove
- */
-function syncPrintHover(show) {
-  // Select both action bar Print button and menu Print button
-  const printButtons = document.querySelectorAll('.print-btn, .menu-print-btn');
-
-  printButtons.forEach(button => {
-    if (show) {
-      button.classList.add('print-hover-sync');
-    } else {
-      button.classList.remove('print-hover-sync');
-    }
-  });
-}
-
-/**
- * Highlight Zoom Control
- * @param {boolean} show - true to highlight, false to remove highlight
- */
-function highlightZoomControl(show) {
-  const zoomWrapper = document.querySelector('#zoom-wrapper');
-
-  if (show) {
-    zoomWrapper?.classList.add('highlight');
-  } else {
-    zoomWrapper?.classList.remove('highlight');
-  }
-}
-
-// Make functions globally available
-window.toggleCVLength = toggleCVLength;
-window.toggleIcons = toggleIcons;
-window.toggleTheme = toggleTheme;
-window.syncPdfHover = syncPdfHover;
-window.syncPrintHover = syncPrintHover;
-window.highlightZoomControl = highlightZoomControl;