refactor: Separate CV domain and UI presentation models into distinct packages

**Main Changes:**

1. **Package Restructuring** - Separated mixed concerns into focused packages:
   - Created `internal/models/cv/` for CV domain logic (CV, Personal, Experience, etc.)
   - Created `internal/models/ui/` for UI presentation logic (InfoModal, ShortcutsModal, etc.)
   - Removed monolithic `internal/models/cv.go` (300+ lines → organized packages)

2. **Testing** - Added comprehensive unit tests:
   - `internal/models/cv/loader_test.go` - CV data loading and validation
   - `internal/models/ui/loader_test.go` - UI translations loading
   - All tests passing 

3. **Documentation** - Added Go learning knowledge base:
   - `_go-learning/architecture/server-design.md` - Goroutines, graceful shutdown explained
   - `_go-learning/refactorings/001-cv-model-separation.md` - This refactoring documented
   - Public documentation showcasing Go expertise (README.md kept private)

4. **Handler Updates** - Updated imports to use new package structure:
   - `internal/handlers/cv.go` - Uses `cvmodel` and `uimodel` aliases

**Benefits:**
-  Clear separation of concerns (domain vs presentation)
-  Better testability (isolated package testing)
-  Improved maintainability (smaller, focused files)
-  Scalability (each domain can evolve independently)
-  Follows Go best practices (small, cohesive packages)

**Other Updates:**
- Updated middleware security checks
- Template improvements
- Organized completed prompts

**Testing:**
- All Go unit tests pass (cv, ui, handlers)
- Server verified with curl tests (English, Spanish, Health endpoints)
- Frontend functionality unchanged (refactoring is transparent to UI)
This commit is contained in:
juanatsap
2025-11-20 16:17:56 +00:00
parent 6999d026c1
commit 7b60fdcf9c
16 changed files with 1890 additions and 15 deletions
+69
View File
@@ -0,0 +1,69 @@
package cv
import (
"encoding/json"
"fmt"
"os"
"strings"
"time"
)
// LoadCV loads CV data from a JSON file for the specified language
func LoadCV(lang string) (*CV, error) {
if lang != "en" && lang != "es" {
return nil, fmt.Errorf("unsupported language: %s", lang)
}
filename := fmt.Sprintf("data/cv-%s.json", lang)
filepath, err := findDataFile(filename)
if err != nil {
return nil, err
}
data, err := os.ReadFile(filepath)
if err != nil {
return nil, fmt.Errorf("error reading file %s: %w", filename, err)
}
var cvData CV
if err := json.Unmarshal(data, &cvData); err != nil {
return nil, fmt.Errorf("error parsing JSON: %w", err)
}
// Replace {{YEAR}} placeholder in reference URLs with current year
currentYear := fmt.Sprintf("%d", time.Now().Year())
for i := range cvData.References {
cvData.References[i].URL = replaceYearPlaceholder(cvData.References[i].URL, currentYear)
}
return &cvData, nil
}
// findDataFile locates a data file by searching up the directory tree
func findDataFile(filename string) (string, error) {
// Try current directory first
if _, err := os.Stat(filename); err == nil {
return filename, nil
}
// Try parent directories (for tests running from subdirectories)
paths := []string{
filename, // Current dir
"../" + filename, // One level up
"../../" + filename, // Two levels up (for tests in internal/handlers)
"../../../" + filename, // Three levels up
}
for _, path := range paths {
if _, err := os.Stat(path); err == nil {
return path, nil
}
}
return "", fmt.Errorf("file not found: %s (searched: current dir, ../, ../../, ../../../)", filename)
}
// replaceYearPlaceholder replaces {{YEAR}} with the current year
func replaceYearPlaceholder(url string, year string) string {
return strings.ReplaceAll(url, "{{YEAR}}", year)
}